Improvements to new resolver #8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
reviewed
Feb 20, 2023
| specifier: &'s str, | ||
| from: &Path, | ||
| specifier_type: SpecifierType, | ||
| options: ResolveOptions, |
There was a problem hiding this comment.
Is there a case where there you'd want no conditions to apply (and then this should be an Option<ResolveOptions>)? Probably not..
There was a problem hiding this comment.
You mean to disable the import/require conditions but not add any in its place? Hmm... not sure.
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mischnic
approved these changes
Feb 21, 2023
marcins
pushed a commit
to marcins/parcel
that referenced
this pull request
Jul 14, 2023
* upstream/v2: Missing edge for multiple targets (parcel-bundler#8854) Split large runtime manifest into separate bundles (parcel-bundler#8837) Improvements to new resolver (parcel-bundler#8844) Fix published files for resolver New resolver implementation in Rust (parcel-bundler#8807) Update yarn.lock (parcel-bundler#8843) Bump napi-rs to latest (parcel-bundler#8838)
lettertwo
added a commit
that referenced
this pull request
Nov 6, 2023
* upstream/v2: (128 commits) [webextension] Add support for `chrome_style` (#8867) Switch to SWC minifier by default (#8860) Use BitSet for bundler intersections (#8862) best key logic truncating package names (#8865) Add support for loadConfig to resolver plugins (#8847) Missing edge for multiple targets (#8854) Split large runtime manifest into separate bundles (#8837) Improvements to new resolver (#8844) Fix published files for resolver New resolver implementation in Rust (#8807) Update yarn.lock (#8843) Bump napi-rs to latest (#8838) Support .proxyrc.cjs (#8833) Sort global deps before injecting imports (#8818) Sort CSS module exports (#8817) fix: add extra information to unique bundles (#8784) Don't blow up HMR when <link />s don't have hrefs (#8800) v2.8.3 Changelog for v2.8.3 Address bug by updating an asset reference and merge conditions (#8762) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements two improvements to the new resolver from #8807 based on feedback in #4155.
.jsonextension can be omitted from the tsconfig "extends" field. The behavior now matches TSC.sass,less,stylus, andstyleconditions that are supported by webpack.For performance reasons, we store commonly used conditions as bit flags in dependencies internally, with custom conditions stored as strings. This is done transparently to plugin authors. The rust resolver also uses a similar strategy.
When
packageConditionsis specified on a dependencies, it overrides the default "import" and "require" conditions that are normally inferred from thespecifierType. These can be included explicitly if desired. This is so dependencies in style files don't use these conditions and end up resolving to JavaScript. The environment-based conditions such as browser/node/production/development/etc are merged with these conditions.This also adds an options parameter to the
resolvefunction that is passed to transformers so that thespecifierTypeandpackageConditionscan be customized.