fix for eslint rule protecting against importing packages that aren't in the package.json #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshdavid
force-pushed
the
alsh/fixing-eslint-dependency-rule
branch
2 times, most recently
from
a340ca8 to
08613c9
Compare
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mischnic
reviewed
Dec 20, 2022
mischnic
reviewed
Dec 20, 2022
mischnic
reviewed
Dec 20, 2022
mischnic
reviewed
Dec 20, 2022
mischnic
reviewed
Dec 20, 2022
alshdavid
commented
Jan 11, 2023
|
The tests are failing now, and there's a merge conflict |
mischnic
reviewed
Mar 26, 2023
BTW, that was released in the meantime with 2.27 |
are declared in that package's package.json.
Note:
This will fail to lint due to correcting the import lint rule
Changelog:
- Updated eslint version to the latest 7.x.x release
- Updated the eslint plugins relevant to the import rule
- Updated the root eslintrc.json to include the import rule
- Note that this rule must be in the root directory of the workspace
See "packageDir" under "options" related to monorepos
https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-extraneous-dependencies.md
- Corrected plugin resolution for @parcel/babel-preset
Changelog: - Updated eslint errors unrelated to imports
- Updated @parcel/source-map version - Added elm as a devDependency - Ignoring node_modules/resolve from flow check
…as a built-in global variable no-redeclare"
mischnic
force-pushed
the
alsh/fixing-eslint-dependency-rule
branch
from
581d539 to
15bec7d
Compare
mischnic
force-pushed
the
alsh/fixing-eslint-dependency-rule
branch
from
4c42950 to
fbc919f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR corrects the misbehaving
eslint-plugin-import/no-extraneous-dependenciesrule, adding protection against using imports that are not defined in a package's package.jsonNote:
This currently excludes type imports like
import type { Foo } from 'foo'due to the current version of eslint-plugin-import not including the change which adds support for type imports.I am not sure when they will merge this, the last update was almost a year ago.
💻 Examples
🚨 Test instructions
As this is a linting rule, to test it you can try importing a package that isn't in that package.json to see if it fails
✔️ PR Todo