Add glob resolver plugin #5933
Merged
Add glob resolver plugin #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
devongovett
commented
Mar 1, 2021
| @@ -220,6 +221,10 @@ export class ResolverRunner { | |||
| }; | |||
| } | |||
|
|
|||
| if (result.isAsync != null) { | |||
| dependency.isAsync = result.isAsync; | |||
There was a problem hiding this comment.
Not totally sure how I feel about mutating the dependency in the resolver, but we did it already for meta... Otherwise we'd need to move isAsync to the AssetGroup, but that's not available in the bundle graph. 😞
mischnic
reviewed
Mar 5, 2021
mischnic
reviewed
Mar 5, 2021
mischnic
reviewed
Mar 5, 2021
|
What is the current status on this? I am working on a project that should use url globs, and as I am relatively new to using Parcel I'm not sure of the best way to implement that. Is this PR expected to be merged soon? For now, I am going to just load the url for each file in my directory individually. (Is there some other plugin I should use instead for now?) Thanks! |
|
I also need this. Would be great if it will be merged. Thanks! |
|
Need this as well, urgently |
|
Very much anticipating this functionality. Doing "animated PNGs" in my current project, which currently involves importing each frame image separately... Loving Parcel, but being able to eliminate hundreds of lines of repetitive code would be a great boon. |
|
This PR would also benefit a lot a project I'm working on with parcel. |
|
We encountered the node-gyp/deasync problem in Parcel 1 (#5294), so we tried to upgrade to Parcel 2. It doesn't do glob imports, so we can't use it. This PR fixes that problem, but 3 months have passed with no activity. So we're stuck on old versions of Node and Parcel. I'd rather not have to move everything off Parcel and onto esbuild, but if this isn't fixed then I'll have to eventually. |
|
Can you use the babel plugin in the meantime? https://github.com/devongovett/babel-plugin-transform-glob-import I believe the current state was that there was disagreement among the core team about how dynamic import should be handled. I hope to get back to this soon. |
|
@devongovett Thanks, I'll give it a try. |
|
@RickyRomero When you're done, could you let us know how it goes for you? Thanks! |
|
@devongovett @DarthFloopy Here's where I got following the migration guide for Parcel 2:
The glob imports we use are for .mp4 files. Our app's video imports look like this: import videos from '../../../../projects-data/**/*.mp4';Prepending Judging from what little I know about Parcel 2, it seems like I should be using the |
Merged
# Conflicts: # packages/core/core/src/AssetGraph.js # yarn.lock
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4683
This creates a
@parcel/resolver-globplugin which resolves glob specifiers. It's not currently in the default config, but can be enabled by adding it to your.parcelrc. It works identically to the Parcel v1 version for JS, and also works for CSS. In addition, it works with pipelines likeurl:, and also for dynamic import. See the tests for examples.