Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR Sourcemaps #5316

Closed
wants to merge 1 commit into from
Closed

HMR Sourcemaps #5316

wants to merge 1 commit into from

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Nov 4, 2020 •
edited
Loading

↪️ Pull Request

Closes #643

@mischnic mischnic mentioned this pull request Nov 4, 2020
Closed
@height
Copy link

height bot commented Nov 4, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 9.48s +56.00ms
Cached 2.22s +86.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 254.00ms -97.00ms 🚀
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 521.00ms +213.00ms ⚠️
dist/legacy/index.45cccf70.js 1.10kb +0.00b 3.14s +164.00ms ⚠️
dist/legacy/index.b3acc8eb.css 77.00b +0.00b 2.97s +192.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 1.76s +201.00ms ⚠️
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 1.68s +127.00ms ⚠️
dist/modern/index.html 701.00b +0.00b 1.86s +256.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 33.70s +57.00ms
Cached 2.18s +43.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/NotFound.9af20955.js 532.00b +0.00b 1.20s -164.00ms 🚀
dist/logo.24c8bf9e.png 274.00b +0.00b 140.00ms -54.00ms 🚀

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 3.53m +4.04s
Cached 5.49s -74.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.61bb65a7.js 2.74mb +6.00b ⚠️ 1.87m +4.15s
dist/pdfRenderer.f8165fbc.js 1.11mb +0.00b 1.05m +6.11s ⚠️
dist/editorView.8e3d6b32.js 586.93kb +0.00b 1.61m +6.53s ⚠️
dist/popup.7f6cfb6d.js 169.23kb +0.00b 1.05m +4.02s ⚠️
dist/dropzone.498ec003.js 17.30kb +0.00b 1.88m +53.09s ⚠️
dist/component.fe59914e.js 6.19kb +0.00b 10.81s +896.00ms ⚠️
dist/dropzone.cca9436f.js 3.32kb +0.00b 1.01m +3.56s ⚠️
dist/clipboard.dddd75a9.js 2.83kb +0.00b 1.05m +3.56s ⚠️
dist/card.bc6d3fe8.js 2.15kb +0.00b 36.04s -20.93s 🚀
dist/16.51a973ae.js 1.86kb +0.00b 6.81s +412.00ms ⚠️
dist/16.664f2364.js 1.79kb +0.00b 6.52s +327.00ms ⚠️
dist/browser.4322401e.js 1.70kb +0.00b 1.05m +3.58s ⚠️
dist/workerHasher.c6b3a06a.js 1.67kb +0.00b 1.06m +3.66s ⚠️
dist/16.3d2fa847.js 1.46kb +0.00b 6.52s +327.00ms ⚠️
dist/16.a99d351e.js 1.44kb +0.00b 6.98s +374.00ms ⚠️
dist/16.c8c5e38d.js 1.40kb +0.00b 6.98s +374.00ms ⚠️
dist/16.039b21a1.js 1.36kb +0.00b 6.81s +410.00ms ⚠️
dist/16.8938ddc0.js 1.32kb +0.00b 6.81s +408.00ms ⚠️
dist/16.955db3fc.js 1.31kb +0.00b 6.98s +374.00ms ⚠️
dist/16.3d8988cf.js 1.27kb +0.00b 6.81s +412.00ms ⚠️
dist/16.5ba30215.js 1.26kb +0.00b 6.81s +412.00ms ⚠️
dist/16.2da93a26.js 1.26kb +0.00b 10.81s +864.00ms ⚠️
dist/media-card-analytics-error-boundary.7bdb6beb.js 1.25kb +0.00b 36.04s -20.92s 🚀
dist/16.eb0e686d.js 1.18kb +0.00b 6.98s +374.00ms ⚠️
dist/action.c1329039.js 1.15kb +0.00b 6.98s +374.00ms ⚠️
dist/media-picker-analytics-error-boundary.debe5415.js 960.00b +0.00b 1.05m +3.56s ⚠️
dist/media-card-analytics-error-boundary.a56d8c27.js 956.00b +0.00b 1.06m -44.86s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.61bb65a7.js 2.74mb +0.00b 557.00ms -117.00ms 🚀
dist/pdfRenderer.f8165fbc.js 1.11mb +0.00b 788.00ms -58.00ms 🚀
dist/editorView.8e3d6b32.js 586.93kb +0.00b 814.00ms -48.00ms 🚀
dist/Toolbar.40472b4f.js 92.38kb +0.00b 814.00ms -48.00ms 🚀
dist/EmojiPickerComponent.ab132fac.js 75.00kb +0.00b 750.00ms -38.00ms 🚀
dist/media-viewer.4c3f658c.js 71.88kb +0.00b 769.00ms -77.00ms 🚀
dist/card.e1c0f362.js 54.82kb +0.00b 769.00ms -77.00ms 🚀
dist/card.9d364a71.js 52.57kb +0.00b 814.00ms -65.00ms 🚀
dist/Modal.f7e71087.js 41.31kb +0.00b 589.00ms -64.00ms 🚀
dist/component.327022bf.js 30.85kb +0.00b 556.00ms -118.00ms 🚀
dist/component.49a28949.js 22.36kb +0.00b 590.00ms -63.00ms 🚀
dist/DatePicker.89ba6023.js 21.07kb +0.00b 731.00ms -70.00ms 🚀
dist/EmojiPickerComponent.7963a811.js 18.12kb +0.00b 750.00ms -39.00ms 🚀
dist/dropzone.498ec003.js 17.30kb +0.00b 806.00ms -43.00ms 🚀
dist/smartMediaEditor.a8b77894.js 16.90kb +0.00b 814.00ms -65.00ms 🚀
dist/js.eb39c3cf.js 16.55kb +0.00b 589.00ms -64.00ms 🚀
dist/component.fe59914e.js 6.19kb +0.00b 598.00ms -55.00ms 🚀
dist/card.7b75c38c.js 5.67kb +0.00b 769.00ms -77.00ms 🚀
dist/EmojiPickerComponent.0c594241.js 3.68kb +0.00b 750.00ms -39.00ms 🚀
dist/png-chunks-extract.3bcd3532.js 3.55kb +0.00b 589.00ms -64.00ms 🚀
dist/index.ac562c80.css 3.46kb +0.00b 867.00ms -95.00ms 🚀
dist/dropzone.cca9436f.js 3.32kb +0.00b 802.00ms -46.00ms 🚀
dist/Modal.725e4b5d.js 3.07kb +0.00b 576.00ms -106.00ms 🚀
dist/clipboard.dddd75a9.js 2.83kb +0.00b 802.00ms -46.00ms 🚀
dist/16.984a552d.js 2.49kb +0.00b 710.00ms +80.00ms ⚠️
dist/EmojiUploadComponent.c023b9c0.js 2.22kb +0.00b 750.00ms -39.00ms 🚀
dist/ResourcedEmojiComponent.4e7708b7.js 2.07kb +0.00b 556.00ms -118.00ms 🚀
dist/date.1de12427.js 1.88kb +0.00b 652.00ms -78.00ms 🚀
dist/16.51a973ae.js 1.86kb +0.00b 622.00ms -80.00ms 🚀
dist/images.bd2c65c2.js 1.82kb +0.00b 664.00ms -66.00ms 🚀
dist/16.664f2364.js 1.79kb +0.00b 606.00ms -75.00ms 🚀
dist/feedback.762993d4.js 1.78kb +0.00b 731.00ms -64.00ms 🚀
dist/browser.4322401e.js 1.70kb +0.00b 802.00ms -46.00ms 🚀
dist/workerHasher.c6b3a06a.js 1.67kb +0.00b 814.00ms -65.00ms 🚀
dist/list-number.140c0835.js 1.60kb +0.00b 675.00ms -67.00ms 🚀
dist/status.eb990fdd.js 1.60kb +0.00b 711.00ms -47.00ms 🚀
dist/code.3d01c3f6.js 1.52kb +0.00b 652.00ms -78.00ms 🚀
dist/16.d03ef2ed.js 1.51kb +0.00b 618.00ms -84.00ms 🚀
dist/16.2560b363.js 1.46kb +0.00b 606.00ms -75.00ms 🚀
dist/16.3d2fa847.js 1.46kb +0.00b 609.00ms -72.00ms 🚀
dist/16.f8607434.js 1.45kb +0.00b 710.00ms +79.00ms ⚠️
dist/link.0f2a27b0.js 1.44kb +0.00b 664.00ms -66.00ms 🚀
dist/heading6.e4e9d5d4.js 1.44kb +0.00b 731.00ms -63.00ms 🚀
dist/16.a99d351e.js 1.44kb +0.00b 632.00ms -70.00ms 🚀
dist/16.c8c5e38d.js 1.40kb +0.00b 632.00ms -72.00ms 🚀
dist/emoji.ea46e5f5.js 1.37kb +0.00b 664.00ms -66.00ms 🚀
dist/16.039b21a1.js 1.36kb +0.00b 632.00ms -70.00ms 🚀
dist/16.f10fd24d.js 1.34kb +0.00b 710.00ms +79.00ms ⚠️
dist/16.8938ddc0.js 1.32kb +0.00b 632.00ms -70.00ms 🚀
dist/heading5.87b6dae6.js 1.31kb +0.00b 731.00ms -63.00ms 🚀
dist/16.955db3fc.js 1.31kb +0.00b 652.00ms -78.00ms 🚀
dist/expand.983a2c37.js 1.30kb +0.00b 731.00ms -64.00ms 🚀
dist/16.d58d6149.js 1.27kb +0.00b 710.00ms +79.00ms ⚠️
dist/16.3d8988cf.js 1.27kb +0.00b 618.00ms -84.00ms 🚀
dist/16.b709596e.js 1.26kb +0.00b 606.00ms -75.00ms 🚀
dist/16.202504a1.js 1.26kb +0.00b 618.00ms -84.00ms 🚀
dist/16.5ba30215.js 1.26kb +0.00b 618.00ms -84.00ms 🚀
dist/16.2da93a26.js 1.26kb +0.00b 606.00ms -74.00ms 🚀
dist/16.a2db69a4.js 1.23kb +0.00b 709.00ms +78.00ms ⚠️
dist/mention.41dd4317.js 1.21kb +0.00b 675.00ms -67.00ms 🚀
dist/layout.a7a50d60.js 1.19kb +0.00b 664.00ms -66.00ms 🚀
dist/16.eb0e686d.js 1.18kb +0.00b 632.00ms -70.00ms 🚀
dist/divider.6cc8acb0.js 1.17kb +0.00b 664.00ms -66.00ms 🚀
dist/quote.b58dc9d4.js 1.16kb +0.00b 711.00ms -47.00ms 🚀
dist/component.f51f4183.js 1.15kb +0.00b 556.00ms -118.00ms 🚀
dist/action.c1329039.js 1.15kb +0.00b 652.00ms -78.00ms 🚀
dist/decision.b8aab464.js 1.13kb +0.00b 652.00ms -78.00ms 🚀
dist/panel-warning.a4dc1737.js 1.13kb +0.00b 711.00ms -47.00ms 🚀
dist/list.6772c571.js 1.10kb +0.00b 675.00ms -67.00ms 🚀
dist/panel-error.2d0a3dc5.js 1.03kb +0.00b 675.00ms -67.00ms 🚀
dist/panel.983b8f36.js 1.02kb +0.00b 711.00ms -47.00ms 🚀
dist/panel-success.f52c4b4f.js 990.00b +0.00b 711.00ms -47.00ms 🚀
dist/panel-note.af0bab14.js 986.00b +0.00b 675.00ms -69.00ms 🚀
dist/media-picker-analytics-error-boundary.debe5415.js 960.00b +0.00b 802.00ms -46.00ms 🚀
dist/media-card-analytics-error-boundary.eaabcc04.js 956.00b +0.00b 769.00ms -77.00ms 🚀
dist/media-card-analytics-error-boundary.a56d8c27.js 956.00b +0.00b 814.00ms -65.00ms 🚀
dist/EmojiPickerComponent.57313a93.js 680.00b +0.00b 750.00ms -39.00ms 🚀
dist/simpleHasher.2437bfc1.js 673.00b +0.00b 814.00ms -65.00ms 🚀
dist/index.html 119.00b +0.00b 402.00ms -42.00ms 🚀

Three.js x4 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Click here to view a detailed benchmark overview.

mischnic
mischnic commented Nov 4, 2020
View reviewed changes
packages/reporters/dev-server/src/HMRServer.js
Comment on lines +141 to +144
format: 'inline',
sourceRoot: '/__parcel_source_root/',
// TODO
// rootDir & fs needed for inlineSources, see PackageRunner#generateSourceMap
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeMoorJasper any thoughts what we should do here? We can't use inlineSources or inline because that's a per-target option.

@devongovett devongovett mentioned this pull request May 1, 2022
Merged
@mischnic mischnic deleted the hmr-sourcemaps-v2 branch May 24, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Source maps don't work with hot reload
2 participants
@mischnic @parcel-benchmark