-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(*): use the full hash to avoid collisions #4800
Conversation
This pull request has been linked to 28 tasks:
|
We don't really update parcel 1 anymore, is there any way we can help you transition to Parcel 2 instead? |
I tried switching to Parcel 2 and almost immediately I found a blocking issue for us which is the absence of multi-target builds. I see that it's in the todo list. I don't think it's good to drop support in the form of bug fixes for Parcel 1 until Parcel 2 is released and considered production-ready. Thanks for a fast response! |
What exactly do you mean by "multi-target builds"? Parcel 1 didn't support this either? |
We are running the following command to build our apps: Using parcel@nightly currently with the same command gives me a following error:
If I just build one of them it gives me files with names like gulpfile.js and gulpfile.css. I guess I need to configure my entries using the programmatic API? |
This usually happens because you have somehow specified an output path for the output bundle but are using multiple entries (which obviously cannot all have the same output filename).
No, does your package.json contain have a |
Thank you very much, I had However, we need to support IE11 and that means using es5 as target. My output files contain arrow functions and I'm not sure why. My
My
and my
I might've missed something but I can't honestly see why. Thank you again. |
|
Yes, they actually do come from the node_modules. All the arrow functions from my code are transformed correctly. Should I use overrides section in my .babelrc to process my dependencies or is there a nicer way? Thank you again. |
I tried using |
babel.config.* is monorepo-wide, but still not for node_modules. Ideally, the "includes" field in babelrc would be respected (#1655). |
I don't actually think |
I think parcel 1 uses babel 6 which transpiles |
I tried using
Unfortunately, there are still arrow functions in the resulting file. I'm running build command with the |
I've worked around by removing a dependency that had arrow functions. I had other issues which I applied various workaround to fix. The last thing I encountered is the optimization being so slow it times out on CI (take more than 10 minutes to optimize css). It's been a hassle to make it work and it still doesn't. I still don't understand why bugfixes for parcel 1 can't be merged, especially since parcel 2 is in this state. Guess I'll switch to webpack. |
@ArsenyYankovsky Parcel 2 is in a state that is almost as stable as Parcel 1, just lacks a bit of docs and plugin api stability. There's also some issues with cache stability but Parcel 1 also had those... Not sure how optimizations time out CI especially css, must be quite some codebase if that happens and would probably also happen with webpack... I also totally agree it's pretty ridiculous that this never has been fixed so far, the original fix for this bug had been created 2 years ago when I encountered it and created a PR. This should've been fixed a long time ago... Back then we also still released Parcel 1 updates... |
↪️ Pull Request
Fixes 3823 and 3747. Switching to Parcel 2 is not an option for us since it's in the Beta and doesn't support multi-target builds. I think it's a pretty critical bug fix and should be fixed in the Parcel 1.
💻 Examples
One example of relative paths that will generate same id is:
../../node_modules/lodash-es/clone.js
../../node_modules/core-js/library/modules/_an-object.js
✔️ PR Todo