Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve error message for pseudo elements followed by selectors #797

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

kdy1
Copy link
Contributor

@kdy1 kdy1 commented Aug 16, 2024

The previous error message was not human-readable.

Unexpected token Ident("h1")

src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now

@devongovett devongovett merged commit 186435f into parcel-bundler:master Aug 28, 2024
3 checks passed
kdy1 added a commit to vercel/next.js that referenced this pull request Sep 12, 2024
### What?

Update `lightningcss`

### Why?

To apply parcel-bundler/lightningcss#796 and
parcel-bundler/lightningcss#797

### How?

 - Closes PACK-3190
 - Closes PACK-3191
@kdy1 kdy1 deleted the error-msg branch September 20, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants