Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for named timeline ranges in @keyframes #787

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Add support for named timeline ranges in @keyframes #787

merged 3 commits into from
Aug 2, 2024

Conversation

grimsteel
Copy link
Contributor

Adds a new item to the KeyframeSelector enum for named timeline ranges (part of scroll-driven animations).

Spec info

I ran build-ast but that changed a ton of things, so I didn't include that in this PR.

Fixes #786

devongovett
devongovett reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/rules/keyframes.rs Outdated Show resolved Hide resolved
@devongovett devongovett merged commit 86ac8f0 into parcel-bundler:master Aug 2, 2024
3 checks passed
@grimsteel grimsteel deleted the keyframes-range-selector branch August 7, 2024 19:37
@ty-abbott ty-abbott mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support named timeline ranges in @keyframes
2 participants
@grimsteel @devongovett