pkg/query: Group by arbitrary labels #5007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 413 of 526 screens tested: view and approve differences detected. Last updated for commit 6dd4dc9. This comment will update as new commits are pushed. |
metalmatze
force-pushed
the
flamegraph-groupby-abitrary-labels
branch
from
62d76fa
to
f439cc5
Compare
metalmatze
changed the title
metalmatze
force-pushed
the
flamegraph-groupby-abitrary-labels
branch
from
45692a1
to
1955d6a
Compare
metalmatze
force-pushed
the
flamegraph-groupby-abitrary-labels
branch
from
1955d6a
to
df9be69
Compare
This will then only select label names for the correct profileType and label matchers
We don't write to it and we don't read it anymore. It's all part of the labels now.
Once we're building the FrostDB query we don't care about the rendering flame graphs anymore and therefore we only pass the group by labels into the selectMerge function. Excluding the possible group by features of flame graphs
metalmatze
force-pushed
the
flamegraph-groupby-abitrary-labels
branch
from
f96fbb6
to
6dd4dc9
Compare
metalmatze
commented
Oct 14, 2024
| @@ -171,6 +171,8 @@ func MustReadAllGzip(t require.TestingT, filename string) []byte { | |||
| } | |||
|
|
|||
| func TestConsistency(t *testing.T) { | |||
| t.Skipf("skipped, need to think how we want to bring back consistency exports without pprof_labels") | |||
There was a problem hiding this comment.
Given we don't store the pprof_labels anymore, it's impossible to export the same profile as pprof download from now on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Parca allowed to group by all
pprof_labelsat once that are part of profiles.With these changes, Parca allows grouping by
labels, which now includes thepprof_labelsand the infrastructurelabels.This allows grouping by
commornamespacewithin an icicle graph.Additionally, grouping by only the
trace_idbut not any other labels likethread_idwill be possible.A simple example
Filter for
runtime.gcBgMarkWorkerin all of your infrastructure. Then group the icicle graph byjobto see the garbage collection byjob.Before
After
Notice the new rows in the second screenshot now with
job=prometheusandjob=parca. Beneath them, we pretty much have the same stack traces that were previously aggregated together.UI
Selecting the labels to group by looks like this now:
We need to think about the Select component within the dropdown... Not ideal right now.