-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
area/ui: Parca design refresh #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Meticulous spotted visual differences in 640 of 680 screens tested: view and approve differences detected. Last updated for commit bd1b96d. This comment will update as new commits are pushed. |
yomete
changed the title
area/ui: Parca design refresh (wip)
area/ui: Parca design refresh
Aug 15, 2024
Three small things:
|
these are all good points. I'll make sure to implement them |
- Added a line to highlight difference between top and bottom visualizations - Fixed width of sum by label dropdown
manojVivek
approved these changes
Sep 2, 2024
brancz
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR #4959 should be looked at, reviewed, and merged in before taking a look at this PR. i.e. #4959 takes precedence over this.Follow up:
Implement new design for compare page