pkg: Use new grpc.NewClient over grpc.Dial

[metalmatze]

• pkg: Use newer grpc.NewClient over deprecated grpc.Dial
• Update deprecated golanglint-ci config

[asubiotto]

Can you add an explanation of why these changes were made to the commit message? I'm not sure what's going on without context. sorry, I had only read the PR title and didn't realize Dial was deprecated

Is NewClient equivalent to Dial?

[alwaysmeticulous]

🤖 Meticulous spotted visual differences in 1 of 423 screens tested: view and approve differences detected.

_{Last updated for commit beeca32. This comment will update as new commits are pushed.}

[asubiotto]

This answers my question: grpc/grpc-go#1786

[asubiotto]

One thing though: shouldn't these lint issues be caught on PR CI? i.e. when the grpc package was upgraded

[metalmatze]

One thing though: shouldn't these lint issues be caught on PR CI? i.e. when the grpc package was upgraded

That's an excellent question. It should indeed have caught it...
It seems like the action as skipped: https://github.com/parca-dev/parca/actions/runs/9236652064/job/25412732712

[metalmatze]

If I understand this config correctly, we can add go.mod to this array?

parca/.github/workflows/go-lint.yml

Lines 42 to 48 in 7ff555c

	[
	"**.go",
	".github/workflows/go-lint.yml",
	".go-version",
	".golangci.yml",
	".node-version"
	]

[asubiotto]

I think we can