fix(snap): ensure arm64 build can be performed from an amd64 machine #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the issue observed in CI, where the arm64 build appears to just stop: https://github.com/parca-dev/parca-agent/actions/runs/10943881277/job/30384611839#step:6:48
|
This line is the indicator that the build fix has worked :) |
jnsgruk
force-pushed
the
fix-snap-release
branch
from
3028d25
to
3c5ff15
Compare
thorfour
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary reason for this PR is to address the failing snap release job.
This job fails because there is no
arm64build to upload, despite the build artifacts being fetched from the previous steps in the process.Further investigation showed that the
snapcraft packfor thearm64snap finished abruptly having not actually generated an artefact. This turns out to be a known bug, which should be addressed in the next snapcraft release. In the mean time, we can work around by just explicitly stating that thearm64snap can bebuilt-onanamd64machine.As a drive-by, a3fefff ensures that when there is a tag present in the goreleaser
metadata.json,it's used to set the version of the snap accordingly.