Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix x86 verification issues with custom labels #2886

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

umanwizard
Copy link
Contributor

Rewrite a problematic section of code in assembly language to force the verifier to accept our program.

Otherwise, clang does something with this code (on x86) that is too clever for the verifier to understand.

@umanwizard umanwizard requested a review from a team as a code owner June 20, 2024 14:54
bpf/unwinders/common.h Outdated Show resolved Hide resolved
@umanwizard umanwizard requested a review from gnurizen June 20, 2024 15:05
@umanwizard umanwizard merged commit 4aed72f into parca-dev:main Jun 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants