Fix off-by-one error in chunk splitting #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the PC of the "end-of-function" marker was exactly one greater than the PC of the last real table entry, and if the unwind entries of the function (including the end-of-function marker) were too big to fit in the current chunk also by exactly one, then we would erroneously take the entire function _except_ the marker, and start the next chunk with the marker. This commit fixes that defect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PC of the "end-of-function" marker was exactly one greater than the PC of the last real table entry, and if the unwind entries of the function (including the end-of-function marker) were too big to fit in the current chunk also by exactly one, then we would erroneously take the entire function except the marker, and start the next chunk with the marker. This commit fixes that defect.
Test Plan
Added a test for this case to maps_test.go