Fix bug where event processors exit on error #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are errors in processing `prefetch` events, the goroutine that processes them would exit silently. If this happened to all the workers, the entire agent would seize up as no more events could be processed. This commit fixes that behavior.
kakkoyun
reviewed
Apr 11, 2024
brancz
reviewed
Apr 11, 2024
They are regular errors
I have now added them |
gnurizen
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are errors in processing
prefetchevents, the goroutine that processes them would exit silently. If this happened to all the workers, the entire agent would seize up as no more events could be processed.This commit fixes that behavior.
Why?
It's easy to reproduce this if I run something that creates a lot of short-lived processes (e.g. C/C++/Rust compilation). The agent eventually gets into a permanently broken state.