Use object file pool cache for unwind information #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
reviewed
Mar 6, 2024
| @@ -451,12 +455,22 @@ func requireNoRedundantRows(t *testing.T, ut CompactUnwindTable) { | |||
| } | |||
| } | |||
|
|
|||
| func objectFile(t testing.TB, path string) (o *objectfile.ObjectFile) { | |||
There was a problem hiding this comment.
Suggested change
| func objectFile(t testing.TB, path string) (o *objectfile.ObjectFile) { | |
| func objectFile(t testing.TB, path string) *objectfile.ObjectFile { |
| @@ -451,12 +455,22 @@ func requireNoRedundantRows(t *testing.T, ut CompactUnwindTable) { | |||
| } | |||
| } | |||
|
|
|||
| func objectFile(t testing.TB, path string) (o *objectfile.ObjectFile) { | |||
| p := objectfile.NewPool(log.NewNopLogger(), prometheus.NewRegistry(), "", 1, 0) | |||
There was a problem hiding this comment.
Putting the pool as a package-level variable and maybe initializing it with an init function is better. You can share the pool between tests.
gnurizen
force-pushed
the
cache-better
branch
2 times, most recently
from
4064e9d
to
85a9c45
Compare
kakkoyun
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.