Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: Make process filtering work #2550

Merged
merged 1 commit into from
Feb 23, 2024
Merged

debug: Make process filtering work #2550

merged 1 commit into from
Feb 23, 2024

Conversation

gnurizen
Copy link
Contributor

No description provided.

@gnurizen gnurizen requested a review from a team as a code owner February 23, 2024 20:30
kakkoyun
kakkoyun approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me for now.

I guess the initial intention was to be able to filter by thread id.
But we can figure things out later.

@kakkoyun kakkoyun merged commit 1a58592 into parca-dev:main Feb 23, 2024
11 of 12 checks passed
@kakkoyun kakkoyun changed the title make process filtering work debug: Make process filtering work Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnurizen @kakkoyun