Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/integration: Add initial tests for ruby and python #2501

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Feb 13, 2024

  • Add Ruby integration tests 91ecbf5
  • Add Python integration tests e95feb6

@kakkoyun kakkoyun requested a review from a team as a code owner February 13, 2024 16:24
@@ -102,7 +102,7 @@ func newMetrics(reg prometheus.Registerer) *metrics {
Name: "parca_agent_process_info_upload_errors_total",
Help: "Total number of debug information upload errors.",
}, []string{"type"}),
metadataDuration: promauto.NewHistogram(prometheus.HistogramOpts{
metadataDuration: promauto.With(reg).NewHistogram(prometheus.HistogramOpts{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nasty!

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!

@kakkoyun kakkoyun force-pushed the add_integration_tests_for_ruby_and_python branch from 1c1ffd2 to e95feb6 Compare February 13, 2024 16:30
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun kakkoyun force-pushed the add_integration_tests_for_ruby_and_python branch from 5d5c916 to aca7b8d Compare February 13, 2024 17:25
@kakkoyun kakkoyun merged commit ce22e6d into main Feb 13, 2024
25 checks passed
@kakkoyun kakkoyun deleted the add_integration_tests_for_ruby_and_python branch February 13, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants