-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for Arm64 DWARF Expressions #2452
Conversation
Rebase on latest, updated testdata repo |
DWARF Expressions are encoded with a `DW_CFA_def_cfa_expression` or `DW_CFA_expression` (as per aarch64 DWARF ABI). However grepping for either in `.eh_frame` debug information did not show any results (including hardcoded PLT patter heuristics) unlike in x86. (See #1058 for the x86 implementation). Tested on system binaries and libc in multiple distros: Debian, Fedora, Centos, Ubuntu Workflow: ``` `docker run -it --network=host arm64v8/fedora bash` `docker cp 0693985d3bba:/ ./fedrepo` `sudo readelf -wf ./fedrepo/bin/* 2>/dev/null | grep DW_CFA_cfa_def_expression` `sudo readelf -wF ./centos-repo/bin/* 2>/dev/null | grep exp` ``` Return an error for now if we come across an expression in Arm64 binaries. Signed-off-by: Sumera Priyadarsini <[email protected]>
ea4c062
to
764a0de
Compare
What's left so that this is still WIP? |
So sorry, didn't see your question earlier. I want to rebase this branch on latest testdata changes but haven't gotten to thoroughly check all the new uploaded binaries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Outdated since #2958 |
Test Plan