pkg/convert: bump github.com/pyroscope-io/jfr-parser from v0.6.0 to … #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/zdyj3170101136/jfr-parser v0.0.0-20230801105541-d66951dc9605
|
Very nice! Let's wait for the upstream PR to be merged, otherwise lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…github.com/zdyj3170101136/jfr-parser v0.0.0-20230801105541-d66951dc9605
Why?
package github.com/pyroscope-io/jfr-parser malloc too much of memory
What?
i reduce 99% percent of memory allocate and 67 % cpu cost in read jfr file:
grafana/jfr-parser#22
How?
1, do not store data as interface, let memory not leak.
2, stream read event, those cache common event type.