-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Node, Connection, Poru #102
Conversation
Damn the CI is failing cause of building website |
Yes cause Paras isn't listening to me to setup the docs and now it's in backlog, & now I'm tired of asking him everyday. |
I don't think custom client Name should be allowed, as the |
then it should be formatted correctly like Poru/5.0.0 or sum. But some libraries allow it tho to set like the name of the discordbot |
Yeah, some libraries do but it's not an good practice although Lavalink hasn't enforced it. And probably NodeLink enforces it I don't remember, have to ask Pedroo. |
NodeLink enforces it. I was in contact with Pedroo. That's why i added it to test if poru also works with NodeLink |
Poru will work nicely with it as it's based on the Lavalink API and will support most features of it. For others Poru will require some custom implementations. |
Currently it does not work cause of the enforcement of the |
I pushed some small fixes also. It's more efficient and takes less space up :) |
Node.ts:
Connection.ts:
Poru.ts:
Have a nice day o/