Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed print bug regarding newlines #65

Merged
merged 1 commit into from
Jan 30, 2015
Merged

Fixed print bug regarding newlines #65

merged 1 commit into from
Jan 30, 2015

Conversation

EliasC
Copy link
Contributor

@EliasC EliasC commented Jan 30, 2015

print "foo" -- has a newline
print("foo") -- has no newline (this is the fix)

Before, print("foo") and print("foo{}", "") printed different
things (newline resp. no newline).

@kikofernandez
Copy link
Contributor

could you rebase this and push it again?
I want to check that we can do a fast forward merge.

when you push, you will have to:

git push origin bugfix/print-parsing -f

@EliasC
Copy link
Contributor Author

EliasC commented Jan 30, 2015

I thought I had rebased... My local log looks like this:

901fd3d * HEAD origin/bugfix/print-parsing bugfix/print-parsing Fixed print bug regarding newlines
e96eb24 | * runtime-types Runtime types generated for passive classes, futures and streams
        |/  
c0e5bb0 * origin/master origin/HEAD master Added support custom trace functions

where runtime-types is a separate branch.

```
print "foo" -- has a newline
print("foo") -- has no newline (this is the fix)
```

Before, `print("foo")` and `print("foo{}", "")` printed different
things (newline resp. no newline).
EliasC added a commit that referenced this pull request Jan 30, 2015
Fixed print bug regarding newlines (with @kikofernandez blessing)
@EliasC EliasC merged commit 0803497 into master Jan 30, 2015
@EliasC EliasC deleted the bugfix/print-parsing branch January 30, 2015 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants