-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed operator precedence #387
Fixed operator precedence #387
Conversation
I'd like to see some more extensive testing, which will help define/understand what normal is. A single file test with lots of possibilities should do the trick. Your tests could be simply showing that |
@supercooldave |
2716983
to
77fa3e1
Compare
Added tests. The tests uses the new printing to avoid having to change them once the new printing is merged. |
#380 is merged, better to do a rebase to make CI happy. |
77fa3e1
to
77603f7
Compare
Fixed! |
|
@albertnetymk This is not a very useful comment. |
@supercooldave Because I didn't elaborate on what coding conventions are broken or what? |
@albertnetymk Precisely. Your comment was akin to "Something is wrong – but I'm not going to tell you what it is." |
@albertnetymk |
There's no strict coding standard, but we have a convention not to exceeding 80 columns and not having trailing spaces. They are very minor. I would merge it as it is if you don't feel like fixing it. |
added tests
77603f7
to
591ea13
Compare
Fixed! |
This looks reasonable! Merging before I go home today. |
Operator precedence is now normal.
Now equality checks bind stronger than logical operators.
Before one had to write
1 == 2 and 5 <= 2
as(1 == 2) and ( 5 <= 2 )
Relates to issue #385