Fix #292: adding tuple in hasSameKind function in Type.hs

[PhucVH888]

This change fixes the issue #292.

[albertnetymk]

I think it's better to add a test case to avoid regression.

[PhucVH888]

I agree with you. Here is the test case:

passive class Foo {
  t : (int,int)

  def foo() : Maybe (int,int)
    Just this.t
}

class Main
  def main() : void
    ()

I previously fixed the issue by inserting areBoth isTupleType || to areBoth isPrimitive ||, then the issue is fixed.

However, before committing to the plenary, I moved the code to areBoth isMaybeType ||, and I found that another issue as the following:

phuc:workspace vo$ encorec test1.enc
Importing module String from /Users/vo/code/encore/bundles/standard/String.enc
encorec: No match in record selector resultType

@EliasC : do you know why?

[EliasC]

@vhphuc: If you move code around in a function, you should generally expect different results! What we want is to say in this particular function is "if both types are tuples, return True", which is what your original fix did. The code in this commit is instead saying "if both types are tuples, check that the result types of both types are of the same kind", which fails as tuples do not have a result type (more technically, there is no field resultType in the constructor TupleType).

Also: Don't forget to add your test case to the test suite! You will probably want to add a print statement to the main method so that you can check that the program compiles and runs as expected (look at the other test cases in src/tests/encore/basic/ for inspiration).

[PhucVH888]

@EliasC: You are right. I found that there is no field resultType in typeMap. I will prepare the test case and place it in src/tests/encore/basic/. Tack!

[EliasC]

I have two issues with the test case:

• There is commented code in the file that should be removed.

• Many functions running the test cases assumes that a certain value is being passed in. It would be easier to read if each function was self-contained, e.g.

  def testFoo() {
    let t = (32, 32) in
      match t with
        (32, 32) => print "success"
        _ => print "fail"
  }
  

  rather than

  def testFoo(t : (int, int)) {
      match t with
        (32, 32) => print "success"
        _ => print "fail"
  }
  

  Of course some functions are testing that arguments can be passed and returned, and in that case you cannot do it in the first way.

After fixing this, I think this could be merged!

[PhucVH888]

For some functions, it is necessary to maintain arguments in case they can passed and returned. With unnecessary arguments in other functions, I omitted already. Ready to commit.

[EliasC]

Ready to commit.

Does this mean that you will be pushing additional material to this PR?

[PhucVH888]

Not really push additional material, but I fix the two aforementioned issues.

[EliasC]

Personally, I would change some more functions according to my latest comment, but I think this is ready to be merged. Will merge later if no one objects.