-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format PrettyCCode.hs #242
Conversation
why? isn't easier to just not write camel case? |
Maybe the title is a bit misleading. Apparently, there's sth missing from the last PR on this issue. The scripts are the ones I used to construct this PR. |
Ok I understand now. I will review this today |
parens (pp_args args) $+$ | ||
(braced_block . pp') body | ||
pp' (Function retTy name args body) = tshow retTy <+> tshow name <> | ||
parens (ppArgs args) $+$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the script is pretty good but cannot deal with indentation issues, such as here, where the indentation is off by one char.
Thank you, @albertnetymk! |
I assigned this to @kikofernandez, as he said he'd review. |
The indentation is off-by-one, but still valid. It's not fixed on purpose, so that manual-editing and auto-editing is not mixed together. |
You can make a second commit for the manual editing. |
@albertnetymk I have been told (by @EliasC) to fix indentation issues many many times. I don't see why this should be different if we have spot it on time (before a merge). I agree with @kaeluka , create then a second commit with the right title. |
Awesome! :) <3 |
First commit is built using above scirpt; second commit is built by manually change the indentation.