Corrected regression of #203 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is |
|
|
|
Sorry, forgot the not there. Updated. |
|
Is |
|
Yes, I feel so. |
This commit fixes the regression that made the following
program (incorrectly) compile:
```
class Main
def main() : void
let app = \(f:a->b, g:b->c, x : a) ->
let y = f(x) in g(x)
in
()
```
It also includes some changes suggested by @albertnetymk.
== Message of the fixed commit ==
This commit fixes two bugs related to matching types:
```
passive class Foo<a>
def foo(x : Bar<a>) : a
x.bar() -- #1 Can't match 'b' with 'a'
passive class Bar<b>
f : b
def init(f : b) : void
this.f = f
def bar() : b
this.f
class Main {
def main() : void {
let
x = new Foo<int>
y = new Bar<int>(42)
in{
print x.foo(y) -- #2 Type 'Bar<int>' does not match expected type 'Bar<t>'
}
}
}
```
The first bug prevented matching two type variables unless they had the
same name. The second one prevented correctly matching against a
parametric type whose parameter was itself the type parameter of the
enclosing class.
|
Done and done! |
|
I also renamed some functions to avoid possible name confusion |
|
I think it could be merged, if there's no objections from others. |
albertnetymk
added a commit
that referenced
this pull request
Aug 13, 2015
Corrected regression of #203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug introduced by #203 (found by @albertnetymk). The following program now (correctly) does not compile: