Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify calls to tracing functions in code generation. #183

Merged
merged 2 commits into from
Jun 10, 2015
Merged

Unify calls to tracing functions in code generation. #183

merged 2 commits into from
Jun 10, 2015

Conversation

albertnetymk
Copy link
Contributor

No description provided.

@EliasC
Copy link
Contributor

EliasC commented Jun 5, 2015

Jenkins says this PR fails. Let me know when it is fixed and I will take a look!

@albertnetymk
Copy link
Contributor Author

It says "out of memory" in the email, so I guess this PR is OK.

@albertnetymk
Copy link
Contributor Author

Skipped largestream if memory is not enough. Now it seems OK.

@EliasC
Copy link
Contributor

EliasC commented Jun 5, 2015

The test for available memory does not seem portable to mac:

grep: /proc/meminfo: No such file or directory
./test.sh: line 54: ((: < 3000000 : syntax error: operand expected (error token is "< 3000000 ")

@EliasC
Copy link
Contributor

EliasC commented Jun 5, 2015

The rest of the PR looks really good! If the test-script is fixed (maybe this belongs to a separate PR?) this can be merged.

@albertnetymk
Copy link
Contributor Author

Indeed, the memory test is not portable. However, it's never meant to be there. I guess I could wrap the whole thing inside a if block so that it only runs if the OS is linux; after all all mac system has enough memory to run largestream. What do you think?

@albertnetymk
Copy link
Contributor Author

Since no one commented on this since my previous comment, I just went with adding the condition check for Linux.

EliasC added a commit that referenced this pull request Jun 10, 2015
Unify calls to tracing functions in code generation.
@EliasC EliasC merged commit d99b2b5 into parapluu:master Jun 10, 2015
@EliasC EliasC deleted the unify-trace branch June 10, 2015 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants