Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update files to be ghc-7.10.1 compliant #136

Merged
merged 1 commit into from
Apr 24, 2015

Conversation

kikofernandez
Copy link
Contributor

No description provided.

@kikofernandez kikofernandez force-pushed the features/ghc-7.10.1 branch 2 times, most recently from a2c627b to 474eca5 Compare April 23, 2015 13:39
@albertnetymk
Copy link
Contributor

Works OK on Linux. Need to rebased onto master, though.

@kaeluka
Copy link
Contributor

kaeluka commented Apr 23, 2015

@albertnetymk What do you mean it needs to be rebased? As opposed to merged? The UI says it's can be merged.

The commit works for me, but the FlexibleContexts should go.

@kikofernandez
Copy link
Contributor Author

Have you updated your ghc to 7.10.1? I tested on Linux and it's needed (same error for @EricIO )

@kikofernandez
Copy link
Contributor Author

@albertnetymk rebased on top of master

@kaeluka
Copy link
Contributor

kaeluka commented Apr 24, 2015

@kikofernandez Wow, that's weird! I'm running version 7.8.4

OK, then leave them :)

@kikofernandez
Copy link
Contributor Author

@kaeluka yeah, this change is for those who use ghc 7.10.1. I agree with you, if you use 7.8.* you are save, but if you start using Encore and get the latest ghc version, then you need this extension

@kaeluka
Copy link
Contributor

kaeluka commented Apr 24, 2015

I understood. Anyway, that means I have no objections to merging this -- go ahead if you agree.

@kikofernandez
Copy link
Contributor Author

Ahhh! I got you, you want me to bring cake next week again! I cannot merge it, it's against THE RULES. Someone else has to do it :)

kaeluka pushed a commit that referenced this pull request Apr 24, 2015
update files to be ghc-7.10.1 compliant
@kaeluka kaeluka merged commit 5ea5fc4 into parapluu:master Apr 24, 2015
@kikofernandez kikofernandez deleted the features/ghc-7.10.1 branch April 24, 2015 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants