Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to replace papi-components with two libraries #716

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

jolierabideau
Copy link
Contributor

@jolierabideau jolierabideau commented Jan 16, 2024

Changes:

  • Remove re-exports of Unsubscriber, UnsubscriberAsync, PlatformEvent, PlatformEventEmitter, and usePromiseOptions from papi-core.service
  • Fix import statements of these items to be from appropriate library
  • Added both libraries to webViewRequire in src/renderer/global-this.model because they are used in hello-world.web-view.html and hello-someone.web-view.html
  • Change fileName function in vite.config.js in both libraries to return index.cjs and index.js, point package.json to new files

This change is Reviewable

tjcouch-sil
tjcouch-sil previously approved these changes Jan 16, 2024
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jolierabideau jolierabideau changed the title Remove re-exports from papi-core.service Follow up to replace papi-components with two libraries Jan 17, 2024
tjcouch-sil
tjcouch-sil previously approved these changes Jan 17, 2024
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

Reviewed 21 of 21 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jolierabideau jolierabideau merged commit 786ce6a into main Jan 17, 2024
7 checks passed
@jolierabideau jolierabideau deleted the 704-remove-reexports-papi-core branch January 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants