-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up to replace papi-components
with two libraries
#716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
papi-core.service
papi-components
with two libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
Reviewed 21 of 21 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Changes:
Unsubscriber
,UnsubscriberAsync
,PlatformEvent
,PlatformEventEmitter
, andusePromiseOptions
frompapi-core.service
webViewRequire
insrc/renderer/global-this.model
because they are used inhello-world.web-view.html
andhello-someone.web-view.html
fileName
function invite.config.js
in both libraries to returnindex.cjs
andindex.js
, pointpackage.json
to new filesThis change is