Updates from electron-react-boilerplate

.erb/scripts/clean.js

@@ -1,4 +1,5 @@
 import rimraf from 'rimraf';
+import fs from 'fs';
 import webpackPaths from '../configs/webpack.paths';
 
 const foldersToRemove = [
@@ -8,5 +9,5 @@ const foldersToRemove = [
 ];
 
 foldersToRemove.forEach((folder) => {
-  rimraf.sync(folder);
+  if (fs.existsSync(folder)) rimraf.sync(folder);
 });

.erb/scripts/delete-source-maps.js

@@ -1,8 +1,11 @@
+import fs from 'fs';
 import path from 'path';
 import rimraf from 'rimraf';
 import webpackPaths from '../configs/webpack.paths';
 
 export default function deleteSourceMaps() {
-  rimraf.sync(path.join(webpackPaths.distMainPath, '*.js.map'));
-  rimraf.sync(path.join(webpackPaths.distRendererPath, '*.js.map'));
+  if (fs.existsSync(webpackPaths.distMainPath))
+    rimraf.sync(path.join(webpackPaths.distMainPath, '*.js.map'));
+  if (fs.existsSync(webpackPaths.distRendererPath))
+    rimraf.sync(path.join(webpackPaths.distRendererPath, '*.js.map'));
 }

.eslintrc.js

@@ -3,18 +3,26 @@ module.exports = {
   rules: {
     // #region ERB rules
 
+    'import/extensions': 'off',
     // A temporary hack related to IDE not resolving correct package.json
     'import/no-extraneous-dependencies': 'off',
+    'import/no-import-module-exports': 'off',
     'import/no-unresolved': 'error',
-    // Since React 17 and typescript 4.1 you can safely disable the rule
+    'react/jsx-filename-extension': 'off',
     'react/react-in-jsx-scope': 'off',
 
     // #endregion
 
     // #region Our rules
 
-    // This is already a Typescript rule, so we don't need it to be reported twice
-    '@typescript-eslint/no-unused-vars': 'off',
+    '@typescript-eslint/no-explicit-any': 'error',
+    '@typescript-eslint/no-non-null-assertion': 'error',
+    'no-redeclare': 'off',
+    '@typescript-eslint/no-redeclare': 'error',
+    'no-shadow': 'off',
+    '@typescript-eslint/no-shadow': 'error',
+    'no-unused-vars': 'off',
+    '@typescript-eslint/no-unused-vars': 'error',
     'comma-dangle': ['error', 'always-multiline'],
     indent: 'off',
     'jsx-a11y/label-has-associated-control': [
@@ -26,20 +34,25 @@ module.exports = {
     // Should use our logger anytime you want logs that persist. Otherwise use console only in testing
     'no-console': 'warn',
     'no-plusplus': ['error', { allowForLoopAfterthoughts: true }],
+    'no-use-before-define': 'off',
     'prettier/prettier': ['warn', { tabWidth: 2, trailingComma: 'all' }],
     'react/jsx-indent-props': ['warn', 2],
     'react/jsx-props-no-spreading': ['error', { custom: 'ignore' }],
     'react/require-default-props': 'off',
 
     // #endregion
   },
+  globals: {
+    globalThis: 'readonly',
+  },
   parserOptions: {
     ecmaVersion: 2020,
     sourceType: 'module',
     project: './tsconfig.json',
     tsconfigRootDir: __dirname,
     createDefaultProgram: true,
   },
+  plugins: ['@typescript-eslint'],
   settings: {
     'import/resolver': {
       // See https://github.com/benmosher/eslint-plugin-import/issues/1396#issuecomment-575727774 for line below

.github/workflows/publish.yml

@@ -43,6 +43,10 @@ jobs:
           npm install
           npm run build
 
+      - name: Install DMG license
+        if: ${{ matrix.os == 'macos-latest' }}
+        run: npm install dmg-license
+
       - name: dotnet build - MacOS and Windows
         if: ${{ matrix.os == 'macos-latest' }}
         run: |

.github/workflows/test.yml

@@ -42,8 +42,11 @@ jobs:
           cache: npm
 
       - name: npm install
-        run: |
-          npm install
+        run: npm install
+
+      - name: Install DMG license
+        if: ${{ matrix.os == 'macos-latest' }}
+        run: npm install dmg-license
 
       - name: dotnet build
         run: npm run build:data-release

assets/assets.d.ts

@@ -1,6 +1,8 @@
 type Styles = Record<string, string>;
 
 declare module '*.svg' {
+  import React = require('react');
+
   export const ReactComponent: React.FC<React.SVGProps<SVGSVGElement>>;
 
   const content: string;

jest.config.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line jest/no-jest-import
 import type { Config } from 'jest';
 import { pathsToModuleNameMapper } from 'ts-jest';
 import { compilerOptions } from './tsconfig.json';
@@ -18,7 +17,7 @@ const config: Config = {
   testEnvironmentOptions: {
     url: 'http://localhost/',
   },
-  testPathIgnorePatterns: ['release/app/dist'],
+  testPathIgnorePatterns: ['release/app/dist', '.erb/dll'],
   transform: {
     '\\.(ts|tsx|js|jsx)$': 'ts-jest',
   },