Fix inconsistent spelling of papi namespaces

[rolfheij-sil]

This change is 

[tjcouch-sil]

Awesome! Thanks for the thorough revision. This is great. Just one thing that needs to be adjusted for accuracy

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rolfheij-sil)

---

src/shared/services/graphql.service.ts line 67 at r1 (raw file):

  const existingPdp = paratextProjectMap.get(projectId);
  if (existingPdp) return { pdp: existingPdp, verseRef: parsedVerseRef };
  const pdp = await get<'ParatextStandard'>('ParatextStandard', projectId);

Oops! Thanks for fixing this one that I missed. Side note: you can remove the <'ParatextStandard'> generic parameter specification now that you have it in the argument. But we don't need to; just fyi for future ease of use :)

---

src/shared/services/project-data-provider.service.ts line 117 at r1 (raw file):

  if (projectType && projectType !== projectTypeFromMetadata)
    logger.warn(
      `Project type for project ${projectId} is ${projectTypeFromMetadata}, but the 'get' function on the ProjectDataProvider was run with mismatching projectType ${projectType}. This could cause issues`,

Unfortunately this is not correct. The mismatching project types here are from the PDP (projectTypeFromMetadata) and from what is put into this papi.projectDataProviders.get function as the first argument (projectType). The get function on the PDP has not been run yet. I recommend revising to something along these lines:

`Project type for project ${projectId} is ${projectTypeFromMetadata}, but `papi.projectDataProviders.get` was run with mismatching projectType ${projectType}. This could cause issues`

[lyonsil]

Looks good to me other than the things TJ pointed out.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rolfheij-sil)

[rolfheij-sil]

Thanks guys!

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tjcouch-sil)

---

src/shared/services/graphql.service.ts line 67 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

Oops! Thanks for fixing this one that I missed. Side note: you can remove the <'ParatextStandard'> generic parameter specification now that you have it in the argument. But we don't need to; just fyi for future ease of use :)

Done

---

src/shared/services/project-data-provider.service.ts line 117 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

Unfortunately this is not correct. The mismatching project types here are from the PDP (projectTypeFromMetadata) and from what is put into this papi.projectDataProviders.get function as the first argument (projectType). The get function on the PDP has not been run yet. I recommend revising to something along these lines:

`Project type for project ${projectId} is ${projectTypeFromMetadata}, but `papi.projectDataProviders.get` was run with mismatching projectType ${projectType}. This could cause issues`

Done.

[tjcouch-sil]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved