Improve resiliance of network request registration and error messages

[lyonsil]

I'm applying some changes make to the tech demo branch back to main.

The most important change here is in PapiClient.cs. If the network service doesn't respond to a request registration within the expected time, then we were causing an exception that hid what was going on. I also increased the timeout (which we could decide to ditch entirely later if we want).

I changed several response error messages to include call stacks because just giving the exception message wasn't enough to easily track down the problem.

---

This change is 

[irahopkinson]

Looks fine to me however it looks like you need to fix some tests.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[lyonsil]

Indeed - Tim's tests were put in after I pulled the tech demo branch, so I didn't see the failures there.

Reviewable status: 5 of 6 files reviewed, all discussions resolved

[irahopkinson]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lyonsil)

---

c-sharp-tests/PapiTestBase.cs line 221 at r2 (raw file):

                MessageResponse response = (MessageResponse)message;
                Assert.That(response.ErrorMessage ?? "", Does.Contain(expectedErrorMessage ?? ""));

What if response.ErrorMessage is null but expectedErrorMessage is not? This will pass won't it?

[lyonsil]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @irahopkinson)

---

c-sharp-tests/PapiTestBase.cs line 221 at r2 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

What if response.ErrorMessage is null but expectedErrorMessage is not? This will pass won't it?

That would not pass. If response.ErrorMessage is null and the expected is not, then it would be checking if the empty string contains something that isn't empty.

I think you might concerned about the opposite. That is, if the actual error message is not null and the expected is null, then this line would pass. However, in that case the next line would fail. That is, the actual response would be false for success, but the expected case would be true.

[tjcouch-sil]

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @irahopkinson)

[irahopkinson]

Reviewable status: complete! all files reviewed, all discussions resolved