Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DataProviders shared interface for data providers #630

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

tjcouch-sil
Copy link
Member

@tjcouch-sil tjcouch-sil commented Nov 8, 2023

Now you don't need to get and specify a bunch of IDataProviders and DataProviderDataTypes from other extensions in order to get the proper types for data providers.

papi.dataProvider.get('data provider name')
useData('data provider name').DataType(selector, default, options)
useProjectData('project id', 'project type').DataType(selector, default, options)

*Note: I may try to swap the parameters for useProjectData in a commit in a bit. The changes may be strange, though, so I may leave it in the end

Relates to #318


This change is Reviewable

lyonsil
lyonsil previously approved these changes Nov 9, 2023
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tjcouch-sil tjcouch-sil merged commit 5a01877 into main Nov 10, 2023
7 checks passed
@tjcouch-sil tjcouch-sil deleted the 318-data-provider-shared-types branch November 10, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants