Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

437 Restart extensions when extensions are added #603

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

jolierabideau
Copy link
Contributor

@jolierabideau jolierabideau commented Oct 30, 2023

Tested with bundled and external extensions.


This change is Reviewable

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jolierabideau)


src/extension-host/services/extension.service.ts line 128 at r1 (raw file):

];

const commandLineExtensionDirectories: string[] = getCommandLineArgumentsGroup(ARG_EXTENSIONS).map(

I'm sorry I steered you wrong on this! I think this type is Uri[] after all, which I think you may have noticed since you swapped the concat back to before the map in the watcher. Thanks for catching that! No big deal unless you end up making other changes.

Copy link
Contributor Author

@jolierabideau jolierabideau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


src/extension-host/services/extension.service.ts line 128 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

I'm sorry I steered you wrong on this! I think this type is Uri[] after all, which I think you may have noticed since you swapped the concat back to before the map in the watcher. Thanks for catching that! No big deal unless you end up making other changes.

Done Yes, I realized it wasn't watching the external paths when I tested!

@jolierabideau jolierabideau merged commit 27b754b into main Oct 30, 2023
7 checks passed
@jolierabideau jolierabideau deleted the 437-watch-extension-dir branch October 30, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch extension directories and restart extensions when extensions are added
2 participants