Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made webview state not stringified entries while preserving check to make sure it is serializable #586

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Made webview state not stringified entries while preserving check to make sure it is serializable #586

merged 1 commit into from
Oct 23, 2023

Conversation

tjcouch-sil
Copy link
Member

@tjcouch-sil tjcouch-sil commented Oct 20, 2023 •
edited by irahopkinson
Loading

Also filed #585 for a follow-up

This change is Reviewable

lyonsil
lyonsil approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tjcouch-sil tjcouch-sil merged commit 5d44822 into main Oct 23, 2023
7 checks passed
@tjcouch-sil tjcouch-sil deleted the types-on-web-view-state branch October 23, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyonsil lyonsil lyonsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjcouch-sil @lyonsil