Fix potential bug on early return

[irahopkinson]

• this was found when adding eslint rule for as PR Add eslint rules #577.

---

This change is 

[tjcouch-sil]

thanks for doing this!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

src/node/services/node-file-system.service.ts line 95 at r1 (raw file):

function fillMissingEntryTypeProperties(
  entryMap: Map<EntryType, Uri[]> = new Map(),
): Map<EntryType, Uri[]> {

This works great as-is, but you could probably put the Object.freeze and Object.fromEntries in here and just have this return DirectoryEntries if you wanted to make it a bit more concise :)

[lyonsil]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[irahopkinson]

src/node/services/node-file-system.service.ts line 95 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

This works great as-is, but you could probably put the Object.freeze and Object.fromEntries in here and just have this return DirectoryEntries if you wanted to make it a bit more concise :)

Yes, that would be more concise but then that would be out of scope for how this function is named and that reality would not be obvious to the calling function. I've left it as is.