Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed readDir unexpectedly giving undefined instead of empty array when there are no matching directories #516

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fixed readDir unexpectedly giving undefined instead of empty array when there are no matching directories #516

merged 1 commit into from
Oct 2, 2023

Conversation

tjcouch-sil
Copy link
Member

@tjcouch-sil tjcouch-sil commented Oct 2, 2023 •
edited by irahopkinson
Loading

Causing extension host crash in project-lookup-backend.service.ts https://discord.com/channels/1064938364597436416/1102584891545223228/1158122304388218972

image

This change is Reviewable

lyonsil
lyonsil approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

FoolRunning
FoolRunning approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@FoolRunning FoolRunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

katherinejensen00
katherinejensen00 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@katherinejensen00 katherinejensen00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tjcouch-sil tjcouch-sil merged commit dd7aeea into main Oct 2, 2023
6 checks passed
@tjcouch-sil tjcouch-sil deleted the no-projects-fix branch October 2, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyonsil lyonsil lyonsil approved these changes

@katherinejensen00 katherinejensen00 katherinejensen00 approved these changes

@FoolRunning FoolRunning FoolRunning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjcouch-sil @FoolRunning @katherinejensen00 @lyonsil