-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docking panel support #43
Conversation
# Conflicts: # src/renderer/App.tsx
Not sure why the windows test check failed. Anyone have any ideas? Maybe a fluke? Can it just be rerun? |
Yeah, just click on the detail button which will take you to the relevant
job from the Action tab. In the top right you can re-run the job
On Thu, 2 Mar 2023 at 8:55 AM, Tim Steenwyk ***@***.***> wrote:
Not sure why the windows test check failed. Anyone have any ideas? Maybe a
fluke? Can it just be rerun?
—
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKS2SLKUGHBKF2HE7U7WVTWZ6SUNANCNFSM6AAAAAAVMKIRMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Blessings, Ira
…---------------------------------------------------------
Ira J Hopkinson
Programmer, Bible Translation Software
SIL International <https://www.sil.org/> | Paratext
<https://paratext.org/> | Scripture Forge <https://scriptureforge.org/>
M: +64 (21) 064-1848
New Zealand Time (UTC +12/13)
Language for a Better Life.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work, Tim! This is exciting stuff! Hoping to abstract rc-dock
away a bit more and keep type safety on some things. Let me know what you think! Would be glad to meet and discuss overall direction and any specifics.
ce6286b
to
034f6ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the philosophical differences we have regarding data types and such that will work for now and can probably be adjusted as we go as needed, looks good. Just one adjustment to a comment :) Thanks for the hard work!
…mall problems I found.
034f6ba
to
881e4da
Compare
# Conflicts: # package-lock.json # package.json # src/renderer/App.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to go! Thanks for all the hard work and persistence!
This is for #31