Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docking panel support #43

Merged
merged 7 commits into from
Mar 9, 2023
Merged

Added docking panel support #43

merged 7 commits into from
Mar 9, 2023

Conversation

FoolRunning
Copy link
Contributor

This is for #31

@FoolRunning
Copy link
Contributor Author

FoolRunning commented Mar 1, 2023

Not sure why the windows test check failed. Anyone have any ideas? Maybe a fluke? Can it just be rerun?
EDIT: FIgured out how to rerun the check. It looks like the mac build was automatically canceled?

@irahopkinson
Copy link
Contributor

irahopkinson commented Mar 2, 2023 via email

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work, Tim! This is exciting stuff! Hoping to abstract rc-dock away a bit more and keep type safety on some things. Let me know what you think! Would be glad to meet and discuss overall direction and any specifics.

cspell.json Outdated Show resolved Hide resolved
src/renderer/App.tsx Outdated Show resolved Hide resolved
src/renderer/App.tsx Outdated Show resolved Hide resolved
src/renderer/App.tsx Outdated Show resolved Hide resolved
src/renderer/App.tsx Outdated Show resolved Hide resolved
src/renderer/Components/docking/ParanextDockLayout.tsx Outdated Show resolved Hide resolved
src/renderer/Components/docking/ParanextDockLayout.tsx Outdated Show resolved Hide resolved
src/shared/data/WebviewTypes.ts Show resolved Hide resolved
src/renderer/Components/docking/ParanextDockLayout.tsx Outdated Show resolved Hide resolved
src/renderer/Components/docking/ParanextDockLayout.tsx Outdated Show resolved Hide resolved
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the philosophical differences we have regarding data types and such that will work for now and can probably be adjusted as we go as needed, looks good. Just one adjustment to a comment :) Thanks for the hard work!

src/renderer/components/docking/ParanextDockLayout.css Outdated Show resolved Hide resolved
src/renderer/App.tsx Outdated Show resolved Hide resolved
src/renderer/Components/docking/ParanextDockLayout.css Outdated Show resolved Hide resolved
# Conflicts:
#	package-lock.json
#	package.json
#	src/renderer/App.tsx
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go! Thanks for all the hard work and persistence!

@FoolRunning FoolRunning merged commit ec5b5ff into main Mar 9, 2023
@FoolRunning FoolRunning deleted the scaffold-docking branch March 9, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants