Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the I in some interface names after reviewing with Ira #162

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

lyonsil
Copy link
Member

@lyonsil lyonsil commented Apr 26, 2023

This change is Reviewable

@lyonsil lyonsil enabled auto-merge (squash) April 26, 2023 22:18
Copy link
Contributor

@katherinejensen00 katherinejensen00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lyonsil)

irahopkinson
irahopkinson previously approved these changes Apr 26, 2023
Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one non-blocking question since it's out of scope for this PR, so ready to merge.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lyonsil)


src/shared/utils/util.ts line 152 at r1 (raw file):

 * This type is basically a pointer to an object.
 */
export interface Container<T> {

I'm not sure this type belongs in this util.ts file. Having said that I'm not sure where else it might go so this is non-blocking.

Copy link
Contributor

@katherinejensen00 katherinejensen00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lyonsil)

Copy link
Member Author

@lyonsil lyonsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lyonsil)


src/shared/utils/util.ts line 152 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

I'm not sure this type belongs in this util.ts file. Having said that I'm not sure where else it might go so this is non-blocking.

I couldn't find a better place to put it, and TJ didn't have another suggestion, so that's why it went where it did. I can move it into it's own file if you think that's better.

Copy link
Contributor

@irahopkinson irahopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lyonsil)

@lyonsil lyonsil merged commit f5191b5 into main Apr 26, 2023
@lyonsil lyonsil deleted the adjust-type-names branch April 26, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants