-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the I in some interface names after reviewing with Ira #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lyonsil)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one non-blocking question since it's out of scope for this PR, so ready to merge.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lyonsil)
src/shared/utils/util.ts
line 152 at r1 (raw file):
* This type is basically a pointer to an object. */ export interface Container<T> {
I'm not sure this type belongs in this util.ts
file. Having said that I'm not sure where else it might go so this is non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lyonsil)
06a6fc1
cd6cd21
to
06a6fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lyonsil)
src/shared/utils/util.ts
line 152 at r1 (raw file):
Previously, irahopkinson (Ira Hopkinson) wrote…
I'm not sure this type belongs in this
util.ts
file. Having said that I'm not sure where else it might go so this is non-blocking.
I couldn't find a better place to put it, and TJ didn't have another suggestion, so that's why it went where it did. I can move it into it's own file if you think that's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lyonsil)
This change is