speed-up commit hook #1314
Merged
speed-up commit hook #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irahopkinson
force-pushed
the
faster-commit
branch
3 times, most recently
from
04e4633
to
5d3355b
Compare
- remove type checking and linting from commit hook. Only format and stylelint --fix (which actually modify files). - check for file changes after build, e.g. `lib/papi.d.ts`
irahopkinson
force-pushed
the
faster-commit
branch
from
5d3355b
to
7577456
Compare
tjcouch-sil
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
.github/workflows/test.yml line 68 at r1 (raw file):
- name: Verify no files changed after build id: verify-changed-files uses: tj-actions/verify-changed-files@v20
Aaay thanks TJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/papi.d.tsNote
Hear is a build that fails (intentionally for testing) https://github.com/paranext/paranext-core/actions/runs/11847734071/job/33017994912?pr=1314
This change is