Fix eslint running "forever" #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfheij-sil
previously approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Looks good to me. But I see that one of the tests on GitHub is failing
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @irahopkinson)
irahopkinson
commented
Apr 4, 2023
There was a problem hiding this comment.
Thanks, it's a really odd failure too. Will look into it more tomorrow. I'm wondering if getting #129 merged first might fix it.
Reviewable status:
- ignore storybook JS bundles
irahopkinson
force-pushed
the
77-fix-lint
branch
from
e50fd69
to
7a28f51
Compare
rolfheij-sil
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is