Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull out electron-builder config #81

Closed
2 tasks done
irahopkinson opened this issue Mar 16, 2023 · 0 comments · Fixed by #82
Closed
2 tasks done

Pull out electron-builder config #81

irahopkinson opened this issue Mar 16, 2023 · 0 comments · Fixed by #82
Assignees
@irahopkinson

Comments

@irahopkinson
Copy link
Contributor

irahopkinson commented Mar 16, 2023 •
edited
Loading

At the moment the electron-builder config takes up about 3/4 of our package.json file (327/534 lines).

  • Move electron-builder config out into its own file to cleanup the package.json file.
  • Prefer a file option that allows comments.
@irahopkinson irahopkinson moved this to 🔖 Open in Paranext Mar 16, 2023
@irahopkinson irahopkinson self-assigned this Mar 16, 2023
@irahopkinson irahopkinson moved this from 🔖 Open to 🏗 In progress in Paranext Mar 16, 2023
This was referenced Mar 16, 2023
Closed
Merged
@irahopkinson irahopkinson moved this from 🏗 In progress to 👀 In review in Paranext Mar 16, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext Mar 16, 2023
irahopkinson added a commit that referenced this issue Oct 15, 2024
@irahopkinson
Squashed 'extensions/src/hello-someone/' changes from 8bc6203ad..c9ab…
b40357e 
…69053

c9ab69053 update dependencies (#83)
d5cec0952 Moved LIBRARY_TYPE to match multi template (#82)
43898cb4f Moved LIBRARY_TYPE to match multi template
94c18cb75 Added tailwind to extension template (#81)
5bce9e0f8 Updated sass
33d69a3d5 Fixed template info comment not closing properly
a3351bb50 Added tailwind to extension template

git-subtree-dir: extensions/src/hello-someone
git-subtree-split: c9ab69053688b482adba4d77144f5cf2b5ff0a3d
irahopkinson added a commit that referenced this issue Oct 15, 2024
@irahopkinson
Squashed 'extensions/src/hello-world/' changes from 8bc6203ad..c9ab69053
7bdd3b4 
c9ab69053 update dependencies (#83)
d5cec0952 Moved LIBRARY_TYPE to match multi template (#82)
43898cb4f Moved LIBRARY_TYPE to match multi template
94c18cb75 Added tailwind to extension template (#81)
5bce9e0f8 Updated sass
33d69a3d5 Fixed template info comment not closing properly
a3351bb50 Added tailwind to extension template

git-subtree-dir: extensions/src/hello-world
git-subtree-split: c9ab69053688b482adba4d77144f5cf2b5ff0a3d
irahopkinson added a commit that referenced this issue Oct 15, 2024
@irahopkinson
Squashed 'extensions/src/legacy-comment-manager/' changes from 8bc620…
1e3b702 
…3ad..c9ab69053

c9ab69053 update dependencies (#83)
d5cec0952 Moved LIBRARY_TYPE to match multi template (#82)
43898cb4f Moved LIBRARY_TYPE to match multi template
94c18cb75 Added tailwind to extension template (#81)
5bce9e0f8 Updated sass
33d69a3d5 Fixed template info comment not closing properly
a3351bb50 Added tailwind to extension template

git-subtree-dir: extensions/src/legacy-comment-manager
git-subtree-split: c9ab69053688b482adba4d77144f5cf2b5ff0a3d
irahopkinson added a commit that referenced this issue Oct 15, 2024
@irahopkinson
Squashed 'extensions/src/platform-scripture/' changes from 8bc6203ad.…
cb26d92 
….c9ab69053

c9ab69053 update dependencies (#83)
d5cec0952 Moved LIBRARY_TYPE to match multi template (#82)
43898cb4f Moved LIBRARY_TYPE to match multi template
94c18cb75 Added tailwind to extension template (#81)
5bce9e0f8 Updated sass
33d69a3d5 Fixed template info comment not closing properly
a3351bb50 Added tailwind to extension template

git-subtree-dir: extensions/src/platform-scripture
git-subtree-split: c9ab69053688b482adba4d77144f5cf2b5ff0a3d
irahopkinson added a commit that referenced this issue Oct 15, 2024
@irahopkinson
Squashed 'extensions/src/platform-scripture-editor/' changes from 8bc…
d55e597 
…6203ad..c9ab69053

c9ab69053 update dependencies (#83)
d5cec0952 Moved LIBRARY_TYPE to match multi template (#82)
43898cb4f Moved LIBRARY_TYPE to match multi template
94c18cb75 Added tailwind to extension template (#81)
5bce9e0f8 Updated sass
33d69a3d5 Fixed template info comment not closing properly
a3351bb50 Added tailwind to extension template

git-subtree-dir: extensions/src/platform-scripture-editor
git-subtree-split: c9ab69053688b482adba4d77144f5cf2b5ff0a3d
irahopkinson added a commit that referenced this issue Oct 15, 2024
@irahopkinson
Squashed 'extensions/src/quick-verse/' changes from 8bc6203ad..c9ab69053
780cde3 
c9ab69053 update dependencies (#83)
d5cec0952 Moved LIBRARY_TYPE to match multi template (#82)
43898cb4f Moved LIBRARY_TYPE to match multi template
94c18cb75 Added tailwind to extension template (#81)
5bce9e0f8 Updated sass
33d69a3d5 Fixed template info comment not closing properly
a3351bb50 Added tailwind to extension template

git-subtree-dir: extensions/src/quick-verse
git-subtree-split: c9ab69053688b482adba4d77144f5cf2b5ff0a3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irahopkinson irahopkinson

Labels
None yet
Projects
Paranext
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pull out electron-builder config paranext/paranext-core
1 participant
@irahopkinson