You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When you close a webview, all of that webview code continues running until you shut down or reload the renderer.
To Reproduce
Steps to reproduce the behavior:
Open the Resource Viewer (only have one open for this test)
Change the verse ref
Notice the latest console log Resource Viewer project ID: ... was added when you changed the verse ref
Close the Resource Viewer tab
Change the verse ref
Unexpectedly, notice that there's at least one more log Resource Viewer project ID: .... This should not happen anymore if this is fixed.
Reload (Ctrl+R)
Notice there are no more Resource Viewer project ID: ... logs
Change the verse ref
Again, notice there are no Resource Viewer project ID: ... logs
Note: this issue is not present in built-in tabs that do not use webviews.
Expected behavior
WebView React roots should be unmounted with root.unmount() when they are destroyed. We may be able to use the onbeforeunload event inside the iframe somewhere.
Describe the bug
When you close a webview, all of that webview code continues running until you shut down or reload the renderer.
To Reproduce
Steps to reproduce the behavior:
Resource Viewer project ID: ...
was added when you changed the verse refResource Viewer project ID: ...
. This should not happen anymore if this is fixed.Resource Viewer project ID: ...
logsResource Viewer project ID: ...
logsNote: this issue is not present in built-in tabs that do not use webviews.
Expected behavior
WebView React roots should be unmounted with
root.unmount()
when they are destroyed. We may be able to use theonbeforeunload
event inside the iframe somewhere.Fixing this may fix #270!
The text was updated successfully, but these errors were encountered: