Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate accidental useData loop still using CPU after closing tab #270

Open
tjcouch-sil opened this issue Jun 28, 2023 · 1 comment
Open

Comments

@tjcouch-sil
Copy link
Member

We had a useData that was constantly causing rerenders because the selector was not wrapped in a useMemo.

Tim closed all his dock views and was still having immensely high CPU usage on the renderer. We would expect closing the hello world tab to drop the CPU usage. I wonder if some useData subscriptions are not properly getting cleaned up in the useEffect returns or if rc-dock's tabs don't actually delete the react components underneath. Or maybe it was some strange loop of dependencies that just kept the callbacks running. Please investigate

@tjcouch-sil tjcouch-sil moved this to 📋Product Backlog in Paranext Jun 28, 2023
@tjcouch-sil tjcouch-sil added this to the External Extension Ready milestone Jun 28, 2023
@lyonsil lyonsil removed this from the External Extension Ready milestone Sep 29, 2023
@tjcouch-sil
Copy link
Member Author

This may be fixed by #578!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📥 For Consideration
Development

No branches or pull requests

2 participants