Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create IconButton component that wraps the MUI IconButton #253

Closed
tombogle opened this issue Jun 21, 2023 · 3 comments
Closed

Create IconButton component that wraps the MUI IconButton #253

tombogle opened this issue Jun 21, 2023 · 3 comments
Assignees
@tombogle
Labels
extensions team Able to be worked on by extensions team

Comments

@tombogle
Copy link
Contributor

tombogle commented Jun 21, 2023 •
edited by katherinejensen00
Loading

As an extension developer, it would be helpful to have a reusable icon button so that the design of the icon button is consistent with that of icon buttons used in the core of platform.bible.

Wrap MUI IconButton.
@tombogle tombogle added this to the Internal Extension Ready milestone Jun 21, 2023
@tjcouch-sil
Copy link
Member

What is the difference between an IconButton and a Button (what we already have) with an image in its children? Like

<Button>
  <img ... />
  Hi, I'm a button with an icon
</Button>

@tombogle
Copy link
Contributor Author

Material UI's IconButton is similar to the Material UI Button except it has a circular ripple designed for a single icon element.

@lyonsil lyonsil moved this to 📋Product Backlog in Paranext Jul 3, 2023
@tjcouch-sil tjcouch-sil added the extensions team Able to be worked on by extensions team label Aug 2, 2023
@katherinejensen00 katherinejensen00 moved this from 📋Product Backlog to 🏗 In progress in Paranext Sep 20, 2023
@katherinejensen00 katherinejensen00 self-assigned this Sep 20, 2023
@katherinejensen00 katherinejensen00 moved this from 🏗 In progress to 🔖 ToDo in Paranext Sep 27, 2023
@tombogle tombogle moved this from 🔖 ToDo to 🏗 In progress in Paranext Sep 27, 2023
tombogle added a commit that referenced this issue Sep 28, 2023
@tombogle
#253: created an IconButton component in papi-components
eff1611
@tombogle tombogle moved this from 🏗 In progress to 👀 In review in Paranext Sep 28, 2023
@tombogle
Copy link
Contributor Author

#474

tombogle added a commit that referenced this issue Sep 29, 2023
@tombogle
#253: created an IconButton component in papi-components (#474)
f10ee78
@tombogle tombogle moved this from 👀 In review to ✅ Done in Paranext Sep 29, 2023
@lyonsil lyonsil removed this from the Internal Extension Ready milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombogle tombogle

Labels
extensions team Able to be worked on by extensions team
Projects
Paranext
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tombogle @FoolRunning @katherinejensen00 @tjcouch-sil @lyonsil