Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate cra-craco-electron #15

Closed
1 of 4 tasks
tjcouch-sil opened this issue Feb 1, 2023 · 2 comments
Closed
1 of 4 tasks

Investigate cra-craco-electron #15

tjcouch-sil opened this issue Feb 1, 2023 · 2 comments
Assignees

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Feb 1, 2023

Investigate https://github.com/sillsdev/cra-craco-electron to determine if we want to restart our app on it.

  • Cost from switching - how long will it take to switch now vs a year from now?
    • Investigate differences from CRA and see if we can adapt ERB
  • Benefits from switching
  • Drawbacks from switching
@tjcouch-sil tjcouch-sil converted this from a draft issue Feb 1, 2023
@irahopkinson irahopkinson self-assigned this Feb 2, 2023
@irahopkinson irahopkinson moved this from 🔖 Open to 🏗 In progress in Paranext Feb 2, 2023
@irahopkinson
Copy link
Contributor

Our repo with ERB already builds for the web. After npm run build (or more specifically npm run build:renderer), open /release/app/dist/renderer/index.html in a browser.

We would need to make some minor adjustments to exclude electron references but if we end up not using electron IPC then we probably don't need to do anything.

@irahopkinson
Copy link
Contributor

If we need to develop exclusively on the web we can just add a script in package.json like "start:web": "cross-env NODE_ENV=development TS_NODE_TRANSPILE_ONLY=true webpack serve --config ./.erb/configs/webpack.config.web.dev.ts", and then create the .erb/configs/webpack.config.web.dev.ts file (we could eject a CRA boilerplate and adapt the webpack config from that).

However, developing React inside electron should cover just about every scenario. Once we have a feature working in electron we can then just run /release/app/dist/renderer/index.html with the appropriate backend to check its working the same.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Paranext Feb 2, 2023
tjcouch-sil added a commit that referenced this issue Apr 8, 2024
19c296602 Fixed dts self-import, used npm workspaces to clear up package issues (#15)
d1718c231 Updated package-lock.json
733ea7f55 Fixed dts self-import, used npm workspaces to clear up package issues

git-subtree-dir: extensions
git-subtree-split: 19c2966024b41a65bee8808e4a9c01b28cdadf26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants