Fix bug with ChapterRangeSelector and revert prop changes (#1109)

paranext · Sep 25, 2024 · e905398 · e905398
2 parents ac9c8aa + 5f31876
commit e905398
Show file tree

Hide file tree

Showing 13 changed files with 1,960 additions and 1,951 deletions.
diff --git a/extensions/src/platform-scripture/src/checks/configure-checks/book-selector.component.tsx b/extensions/src/platform-scripture/src/checks/configure-checks/book-selector.component.tsx
@@ -22,7 +22,9 @@ export default function BookSelector({
   selectedBookIds,
   handleSelectBooks,
   chapterCount,
+  endChapter,
   handleSelectEndChapter,
+  startChapter,
   handleSelectStartChapter,
 }: BookSelectorProps) {
   const [bookSelectionMode, setBookSelectionMode] = useState<BookSelectionMode>(
@@ -74,6 +76,8 @@ export default function BookSelector({
               handleSelectStartChapter={handleSelectStartChapter}
               handleSelectEndChapter={handleSelectEndChapter}
               chapterCount={chapterCount}
+              startChapter={startChapter}
+              endChapter={endChapter}
             />
           </div>
         </div>

diff --git a/extensions/src/platform-scripture/src/checks/configure-checks/configure-checks.component.tsx b/extensions/src/platform-scripture/src/checks/configure-checks/configure-checks.component.tsx
@@ -129,6 +129,8 @@ export default function ConfigureChecks({
           chapterCount={chapterCount}
           handleSelectStartChapter={setStartChapter}
           handleSelectEndChapter={setEndChapter}
+          startChapter={startChapter}
+          endChapter={endChapter}
         />
       </fieldset>
     </div>

diff --git a/lib/platform-bible-react/dist/index.cjs b/lib/platform-bible-react/dist/index.cjs
diff --git a/lib/platform-bible-react/dist/index.cjs.map b/lib/platform-bible-react/dist/index.cjs.map
diff --git a/lib/platform-bible-react/dist/index.d.ts b/lib/platform-bible-react/dist/index.d.ts
@@ -342,12 +342,14 @@ export type ScrollGroupSelectorProps = {
 /** Selector component for choosing a scroll group */
 export function ScrollGroupSelector({ availableScrollGroupIds, scrollGroupId, onChangeScrollGroupId, localizedStrings, }: ScrollGroupSelectorProps): import("react/jsx-runtime").JSX.Element;
 export type ChapterRangeSelectorProps = {
+	startChapter: number;
+	endChapter: number;
 	handleSelectStartChapter: (chapter: number) => void;
 	handleSelectEndChapter: (chapter: number) => void;
 	isDisabled?: boolean;
 	chapterCount: number;
 };
-export function ChapterRangeSelector({ handleSelectStartChapter, handleSelectEndChapter, isDisabled, chapterCount, }: ChapterRangeSelectorProps): import("react/jsx-runtime").JSX.Element;
+export function ChapterRangeSelector({ startChapter, endChapter, handleSelectStartChapter, handleSelectEndChapter, isDisabled, chapterCount, }: ChapterRangeSelectorProps): import("react/jsx-runtime").JSX.Element;
 export declare enum LabelPosition {
 	After = "after",
 	Before = "before",
@@ -467,8 +469,8 @@ export type ComboBoxProps<T> = {
 	buttonVariant?: ButtonProps["variant"];
 	/** Text direction ltr or rtl */
 	dir?: Direction;
-	/** Component is not enabled when true */
-	disabled?: boolean;
+	/** Optional boolean to set if trigger should be disabled */
+	isDisabled?: boolean;
 } & PopoverProps;
 export type Direction = "ltr" | "rtl";
 /**
@@ -477,7 +479,7 @@ export type Direction = "ltr" | "rtl";
  * Thanks to Shadcn for heavy inspiration and documentation
  * https://ui.shadcn.com/docs/components/combobox
  */
-export declare function ComboBox<T extends ComboBoxOption = ComboBoxOption>({ id, options, className, value, onChange, getOptionLabel, buttonPlaceholder, textPlaceholder, commandEmptyMessage, buttonVariant, dir, disabled, ...props }: ComboBoxProps<T>): import("react/jsx-runtime").JSX.Element;
+export declare function ComboBox<T extends ComboBoxOption = ComboBoxOption>({ id, options, className, value, onChange, getOptionLabel, buttonPlaceholder, textPlaceholder, commandEmptyMessage, buttonVariant, dir, isDisabled, ...props }: ComboBoxProps<T>): import("react/jsx-runtime").JSX.Element;
 export type MenuItemInfoBase = {
 	/** Text (displayable in the UI) as the name of the menu item */
 	label: string;