-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature force reset #152
Feature force reset #152
Conversation
Signed-off-by: Akshay Gaikwad <[email protected]>
Signed-off-by: mabhi <[email protected]>
@akshay196 please check |
|
Signed-off-by: mabhi <[email protected]>
ensure to run npm run format for every commit |
Signed-off-by: mabhi <[email protected]>
…ings Signed-off-by: mabhi <[email protected]>
…new endpoint Signed-off-by: mabhi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits
src/actions/Users.js
Outdated
@@ -188,6 +190,19 @@ export function editUser(params) { | |||
}; | |||
} | |||
|
|||
export function updateForceReset(ud, successcb, errcb) { | |||
ud.spec.forceReset = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont need to send user as input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As user information is already being passed via cookies, removed the above.
… vars from userlist Signed-off-by: mabhi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.md
npm run format
(if applicable)CHANGELOG.md