Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature force reset #152

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Feature force reset #152

merged 8 commits into from
Jan 27, 2023

Conversation

mabhi
Copy link
Contributor

@mabhi mabhi commented Jan 10, 2023

What does this PR change?

  • Added feature that navigates user to the password reset screen, if they haven't done so after the identity got created.

Does the PR depend on any other PRs or Issues? If yes, please list them.

Checklist

I confirm, that I have...

  • [] Read and followed the contributing guide in CONTRIBUTING.md
  • Added tests for this PR
  • Formatted the code using npm run format (if applicable)
  • Updated documentation on the Paralus docs site (if applicable)
  • [] Updated CHANGELOG.md

@mabhi
Copy link
Contributor Author

mabhi commented Jan 10, 2023

@akshay196 please check

@mabhi
Copy link
Contributor Author

mabhi commented Jan 10, 2023 •
edited
Loading

  • Navigate users to dashboard instead of login screen after password reset and also provide link to navigate in case user does not want to wait
  • Provide new generated password instead of recovery link and reset forceReset flag during user create
  • Keep existing flow for password reset for existing users
  • Complete flow for generic users
  • Show generated password during reset password and create user actions for admin

@mabhi mabhi marked this pull request as draft January 10, 2023 12:20
@mabhi mabhi marked this pull request as ready for review January 11, 2023 18:15
@niravparikh05
Copy link
Contributor

ensure to run npm run format for every commit

This was referenced Jan 13, 2023
Closed
Closed
niravparikh05
niravparikh05 reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@niravparikh05 niravparikh05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits

src/appMain/routes/users/routes/UsersList/UserList.js Outdated Show resolved Hide resolved
src/actions/Users.js Outdated
@@ -188,6 +190,19 @@ export function editUser(params) {
};
}

export function updateForceReset(ud, successcb, errcb) {
ud.spec.forceReset = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need to send user as input

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As user information is already being passed via cookies, removed the above.

src/containers/Auth/KratosSettings.js Outdated Show resolved Hide resolved
src/containers/Auth/KratosSettings.js Outdated Show resolved Hide resolved
niravparikh05
niravparikh05 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@niravparikh05 niravparikh05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niravparikh05 niravparikh05 merged commit 278300f into paralus:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niravparikh05 niravparikh05 niravparikh05 approved these changes

@akshay196 akshay196 Awaiting requested review from akshay196 akshay196 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabhi @niravparikh05 @akshay196