Fix managed cluster access button for read only users #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f user in cluster list and menu actions in tabular mode
…f user in cluster list and menu actions in tabular mode Fix access to cluster manage buttons shown for READ-ONLY permission of user in cluster list and menu actions in tabular mode Fix access to cluster manage buttons shown for READ-ONLY permission of user in cluster list and menu actions in tabular mode
…f user in cluster list and menu actions in tabular mode
niravparikh05
requested changes
Nov 29, 2022
…f user in cluster list and menu actions in tabular mode. Added filter of oraganization scoped roles during validation
|
@niravparikh05 Yes, we can disable or hide the new cluster option. I have added the changes |
niravparikh05
approved these changes
Dec 5, 2022
| @@ -1197,8 +1197,8 @@ class PrivateEdgeList extends React.Component { | |||
| const { order, orderBy, selected, rowsPerPage, page } = this.state; | |||
| const { match, UserSession, Projects, sshEdges, partnerDetail } = | |||
| this.props; | |||
| console.log(this.props); | |||
| @@ -1197,8 +1197,8 @@ class PrivateEdgeList extends React.Component { | |||
| const { order, orderBy, selected, rowsPerPage, page } = this.state; | |||
| const { match, UserSession, Projects, sshEdges, partnerDetail } = | |||
| this.props; | |||
| console.log(this.props); | |||
There was a problem hiding this comment.
let's remove this if it was used just for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.mdnpm run format(if applicable)CHANGELOG.md