-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix managed cluster access button for read only users #146
Fix managed cluster access button for read only users #146
Conversation
…f user in cluster list and menu actions in tabular mode
…f user in cluster list and menu actions in tabular mode Fix access to cluster manage buttons shown for READ-ONLY permission of user in cluster list and menu actions in tabular mode Fix access to cluster manage buttons shown for READ-ONLY permission of user in cluster list and menu actions in tabular mode
…f user in cluster list and menu actions in tabular mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roles which are organization scoped are applicable to all projects
…f user in cluster list and menu actions in tabular mode. Added filter of oraganization scoped roles during validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not show New Cluster option if user does not have cluster write access as well
@niravparikh05 Yes, we can disable or hide the new cluster option. I have added the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -1197,8 +1197,8 @@ class PrivateEdgeList extends React.Component { | |||
const { order, orderBy, selected, rowsPerPage, page } = this.state; | |||
const { match, UserSession, Projects, sshEdges, partnerDetail } = | |||
this.props; | |||
console.log(this.props); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
@@ -1197,8 +1197,8 @@ class PrivateEdgeList extends React.Component { | |||
const { order, orderBy, selected, rowsPerPage, page } = this.state; | |||
const { match, UserSession, Projects, sshEdges, partnerDetail } = | |||
this.props; | |||
console.log(this.props); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this if it was used just for debugging
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.md
npm run format
(if applicable)CHANGELOG.md