Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ape Staking V2 #403

Merged
merged 106 commits into from
Dec 11, 2023
Merged

Ape Staking V2 #403

merged 106 commits into from
Dec 11, 2023

Conversation

zhoujia6139
Copy link
Contributor

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

GopherJ and others added 30 commits May 4, 2023 18:56
@GopherJ
feat: improve auto compound
2aca3a0 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: fallback to onchain slippage
09205a5 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
feat: change p2p fee logic
4935ac5 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
feat: seperate compoundBot & matchingOperator
35f9863 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
feat: put slippage offchain
807b966 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: lint
7b42745 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: typo
6e1c2dd 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: gas optimize
c686c37 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: gas optimize
cc60418 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: check swapAmount before transfer
4270ed3 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: part of tests
a174e33 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: auto compound tests
ec2dc1c 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: cleanup
b6a3b37 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: remove unused bot params
ffef685 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: increase precision
4f21916 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: use real price
a372a1a 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: use swapPercent instead
5980e00 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
Merge branch 'main' into improve/auto-compound
0d81db9
@GopherJ
chore: update verify docs & add shelljs
c33aee9 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
Merge remote-tracking branch 'origin/main' into improve/auto-compound
f03f9c7
@GopherJ
chore: update submodules
922e77a 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: add safe owner interface
3a3f074 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: use https for ethereumjs-abi
52ca0b2 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: try fix ci
734ae74 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: add missing phantom enum items
3322f6e 
Signed-off-by: GopherJ <[email protected]>
@zhoujia6139
chore: remove matching operator feature
833bf75
@zhoujia6139
chore: allow transfer to sender address
8992d77
@zhoujia6139
chore: add pause and ACL for P2P
efb8f0d
@zhoujia6139
chore: fix FUN-POOL-05: User can withdraw $APE without timeLock
4c51fac
@zhoujia6139
chore: fix bakc owner check
400fae0
@zhoujia6139 zhoujia6139 requested review from a team as code owners August 15, 2023 08:38
This was referenced Aug 15, 2023
Closed
Closed
Closed
@zhoujia6139 zhoujia6139 changed the base branch from main to l2_deployment_and_cross_chain December 11, 2023 03:59
@zhoujia6139 zhoujia6139 merged commit 89ad917 into l2_deployment_and_cross_chain Dec 11, 2023
0 of 4 checks passed
@zhoujia6139 zhoujia6139 deleted the ape_staking_vault branch December 11, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhoujia6139 @GopherJ