Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy_duplication_select to Context #278

Merged

Conversation

wiktor-k
Copy link
Collaborator

This function causes conditional gating based on duplication parent's
name (and optionally on the name of the object being duplicated).

The duplication tests have been adjusted to utilize this policy
function. The old code based on policy_command_code is still being
tested in Context::duplicate doctests.

I've got a couple of questions I'll be attaching them to the code in a minute...

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll wait to see the version with Optional name!

Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

This looks good to me.

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, but you can tackle them in a separate PR.

@wiktor-k wiktor-k force-pushed the add-policy-duplication-select branch from bc7bd32 to d101b4a Compare October 27, 2021 09:40
This function causes conditional gating based on duplication parent's
name (and optionally on the name of the object being duplicated).

The duplication tests have been adjusted to utilize this policy
function. The old code based on `policy_command_code` is still being
tested in `Context::duplicate` doctests.

Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
@Superhepper Superhepper merged commit 820fe3b into parallaxsecond:main Oct 27, 2021
@wiktor-k wiktor-k deleted the add-policy-duplication-select branch October 27, 2021 10:18
tgonzalezorlandoarm pushed a commit to tgonzalezorlandoarm/rust-tss-esapi that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants