-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy_duplication_select
to Context
#278
Add policy_duplication_select
to Context
#278
Conversation
tss-esapi/src/context/tpm_commands/enhanced_authorization_ea_commands.rs
Show resolved
Hide resolved
tss-esapi/tests/integration_tests/context_tests/tpm_commands/duplication_commands_tests.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'll wait to see the version with Option
al name!
tss-esapi/tests/integration_tests/context_tests/tpm_commands/duplication_commands_tests.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, but you can tackle them in a separate PR.
tss-esapi/tests/integration_tests/context_tests/tpm_commands/duplication_commands_tests.rs
Show resolved
Hide resolved
tss-esapi/tests/integration_tests/context_tests/tpm_commands/duplication_commands_tests.rs
Outdated
Show resolved
Hide resolved
bc7bd32
to
d101b4a
Compare
This function causes conditional gating based on duplication parent's name (and optionally on the name of the object being duplicated). The duplication tests have been adjusted to utilize this policy function. The old code based on `policy_command_code` is still being tested in `Context::duplicate` doctests. Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Add Changelog file (parallaxsecond#278)
This function causes conditional gating based on duplication parent's
name (and optionally on the name of the object being duplicated).
The duplication tests have been adjusted to utilize this policy
function. The old code based on
policy_command_code
is still beingtested in
Context::duplicate
doctests.I've got a couple of questions I'll be attaching them to the code in a minute...